r41940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41939‎ | r41940 | r41941 >
Date:17:43, 10 October 2008
Author:simetrical
Status:old
Tags:
Comment:
(bug 15928) Make special pages dropdown inline

There was a weird extra "|" at the end of lines in Nostalgia (probably other non-MonoBook skins too). Upon investigation, I found that the special pages dropdown (which immediately followed that separator but on the next line) had a class="inline", which actually did nothing but whose intent was fairly obvious. I removed the presentational class and just styled it using the id, so now the separator actually . . . separates.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -1390,7 +1390,7 @@
13911391 $sp = wfMsg( 'specialpages' );
13921392 $spp = $wgContLang->specialPage( 'Specialpages' );
13931393
1394 - $s = '<form id="specialpages" method="get" class="inline" ' .
 1394+ $s = '<form id="specialpages" method="get" ' .
13951395 'action="' . htmlspecialchars( "{$wgServer}{$wgRedirectScript}" ) . "\">\n";
13961396 $s .= "<select name=\"wpDropdown\">\n";
13971397 $s .= "<option value=\"{$spp}\">{$sp}</option>\n";
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1385,7 +1385,7 @@
13861386 * to ensure that client-side caches don't keep obsolete copies of global
13871387 * styles.
13881388 */
1389 -$wgStyleVersion = '180';
 1389+$wgStyleVersion = '181';
13901390
13911391
13921392 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
——@@ -259,6 +259,7 @@
260260 * (bug 15795) Special:Userrights is now listed on Special:SpecialPages when the
261261 user can only change his rights
262262 * (bug 15846) Categories "leak" from older revisions in certain circumstances
 263+* (bug 15928) Special pages dropdown should be inline in non-MonoBook skins
263264
264265 === API changes in 1.14 ===
265266
Index: trunk/phase3/skins/common/oldshared.css
——@@ -416,3 +416,7 @@
417417 vertical-align: middle;
418418 font-size: 90%;
419419 }
 420+
 421+form#specialpages {
 422+ display: inline;
 423+}

Status & tagging log