r41923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41922‎ | r41923 | r41924 >
Date:06:00, 10 October 2008
Author:krimpet
Status:old
Tags:
Comment:
Fix template-included categories from 'leaking' from older revisions when cascading protection is on.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -258,6 +258,7 @@
259259 * (bug 15869) Nostalgia skin does not show page title in printable mode
260260 * (bug 15795) Special:Userrights is now listed on Special:SpecialPages when the
261261 user can only his rights
 262+* (bug 15846) Categories "leak" from older revisions in certain circumstances
262263
263264 === API changes in 1.14 ===
264265
Index: trunk/phase3/includes/Article.php
@@ -3522,7 +3522,7 @@
35233523 $wgUseFileCache = false;
35243524 }
35253525
3526 - if ( !wfReadOnly() && $this->mTitle->areRestrictionsCascading() ) {
 3526+ if ( $this->isCurrent() && !wfReadOnly() && $this->mTitle->areRestrictionsCascading() ) {
35273527 // templatelinks table may have become out of sync,
35283528 // especially if using variable-based transclusions.
35293529 // For paranoia, check if things have changed and if

Status & tagging log