r41920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41919‎ | r41920 | r41921 >
Date:01:32, 10 October 2008
Author:tstarling
Status:old
Tags:
Comment:
Added 'deferred' status.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRevision.php
@@ -80,7 +80,7 @@
8181 }
8282
8383 static function getPossibleStates() {
84 - return array( 'new', 'fixme', 'resolved', 'ok' );
 84+ return array( 'new', 'fixme', 'resolved', 'ok', 'deferred' );
8585 }
8686
8787 function isValidStatus( $status ) {
Index: trunk/extensions/CodeReview/codereview.sql
@@ -51,7 +51,8 @@
5252 -- 'fixme': This revision has some problem which needs to be resolved
5353 -- 'resolved': Issues with this rev have been since resolved
5454 -- 'ok': Reviewed, no issues
55 - cr_status enum('new', 'fixme', 'resolved', 'ok') not null default 'new',
 55+ -- 'deferred': Not reviewed at this time (usually non-Wikimedia extension)
 56+ cr_status enum('new', 'fixme', 'resolved', 'ok', 'deferred') not null default 'new',
5657
5758 -- Base path of this revision :
5859 -- * if the revision change only one file, the file path
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -62,6 +62,7 @@
6363 'code-status-fixme' => 'fixme',
6464 'code-status-resolved' => 'resolved',
6565 'code-status-ok' => 'ok',
 66+ 'code-status-deferred' => 'deferred',
6667 'code-rev-submit' => 'Commit changes',
6768
6869 'codereview-reply-link' => 'reply',

Status & tagging log