| Index: trunk/extensions/CodeReview/CodeReview.php |
| — | — | @@ -93,7 +93,7 @@ |
| 94 | 94 | $wgSubversionProxyTimeout = 30; // default 3 secs is too short :) |
| 95 | 95 | |
| 96 | 96 | |
| 97 | | -$wgCodeReviewStyleVersion = 1; |
| | 97 | +$wgCodeReviewStyleVersion = 2; |
| 98 | 98 | // The name of a repo which represents the code running on this wiki, used to highlight active revisions |
| 99 | 99 | $wgWikiSVN = 'MediaWiki'; |
| 100 | 100 | |
| Index: trunk/extensions/CodeReview/codereview.css |
| — | — | @@ -2,6 +2,11 @@ |
| 3 | 3 | vertical-align: top; |
| 4 | 4 | } |
| 5 | 5 | |
| | 6 | +.mw-codereview-paths { |
| | 7 | + max-height:600px; |
| | 8 | + overflow:auto; |
| | 9 | +} |
| | 10 | + |
| 6 | 11 | .mw-codereview-comment { |
| 7 | 12 | border: solid 1px #aaaab3; |
| 8 | 13 | padding: 0px; |
| — | — | @@ -47,6 +52,11 @@ |
| 48 | 53 | } |
| 49 | 54 | |
| 50 | 55 | /* Diffs */ |
| | 56 | +.mw-codereview-diff { |
| | 57 | + max-width:100%; |
| | 58 | + overflow:auto; |
| | 59 | +} |
| | 60 | + |
| 51 | 61 | .mw-codereview-diff ins { |
| 52 | 62 | text-decoration: none; |
| 53 | 63 | color: green; |
| Index: trunk/extensions/CodeReview/CodeRevisionView.php |
| — | — | @@ -37,7 +37,7 @@ |
| 38 | 38 | $paths .= $this->formatPathLine( $row->cp_path, $row->cp_action ); |
| 39 | 39 | } |
| 40 | 40 | if( $paths ){ |
| 41 | | - $paths = "<ul style='max-height:600px; overflow:auto;'>\n$paths</ul>\n"; |
| | 41 | + $paths = "<div class='mw-codereview-paths'><ul>\n$paths</ul></div>\n"; |
| 42 | 42 | } |
| 43 | 43 | $fields = array( |
| 44 | 44 | 'code-rev-repo' => $repoLink, |
| — | — | @@ -68,8 +68,10 @@ |
| 69 | 69 | wfMsg('code-rev-purge-link'), 'action=purge' ) . ']</small></h2>' . |
| 70 | 70 | "<div class='mw-codereview-diff'>" . $diffHtml . "</div>\n"; |
| 71 | 71 | } |
| 72 | | - $html .= "<h2 id='code-comments'>". wfMsgHtml( 'code-comments' ) ."</h2>\n" . |
| 73 | | - $this->formatComments(); |
| | 72 | + $comments = $this->formatComments(); |
| | 73 | + if( $comments ) { |
| | 74 | + $html .= "<h2 id='code-comments'>". wfMsgHtml( 'code-comments' ) ."</h2>\n" . $comments; |
| | 75 | + } |
| 74 | 76 | |
| 75 | 77 | if( $this->mReplyTarget ) { |
| 76 | 78 | global $wgJsMimeType; |