r41857 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41856‎ | r41857 | r41858 >
Date:21:07, 8 October 2008
Author:aaron
Status:old
Tags:
Comment:
(bug 15898) Fix namespace check to always catch rows that should not be highlighted in contribs
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -1215,9 +1215,11 @@
12161216
12171217 public static function addToContribsLine( $contribs, &$ret, $row ) {
12181218 global $wgFlaggedRevsNamespaces;
1219 - if( isset($row->fp_stable) && $row->rev_id > $row->fp_stable ) {
 1219+ if( !in_array($row->page_namespace,$wgFlaggedRevsNamespaces) ) {
 1220+ // do nothing
 1221+ } else if( isset($row->fp_stable) && $row->rev_id > $row->fp_stable ) {
12201222 $ret = '<span class="flaggedrevs-unreviewed">'.$ret.'</span>';
1221 - } else if( !isset($row->fp_stable) && in_array($row->page_namespace,$wgFlaggedRevsNamespaces) ) {
 1223+ } else if( !isset($row->fp_stable) ) {
12221224 $ret = '<span class="flaggedrevs-unreviewed2">'.$ret.'</span>';
12231225 }
12241226 return true;

Status & tagging log