r41798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41797‎ | r41798 | r41799 >
Date:07:56, 7 October 2008
Author:raymond
Status:old
Tags:
Comment:
Cleanup for r41782: use a common class, not a series of specific IDs.
Per Brions codereview: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/41782#c124
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -279,20 +279,12 @@
280280 * Page protection warning
281281 * incl. log entries for these warnings
282282 */
283 -div#mw-upload-deleted-warn,
284 -div#mw-deleted-notice,
285 -div#mw-recreate-deleted-warn,
286 -div#mw-edit-semiprotectedpagewarning,
287 -div#mw-edit-protectedpagewarning {
 283+div.mw-warning-with-logexcerpt {
288284 padding: 3px;
289285 margin-bottom: 3px;
290286 border: 2px solid #2F6FAB;
291287 }
292 -div#mw-upload-deleted-warn ul li,
293 -div#mw-deleted-notice ul li,
294 -div#mw-recreate-deleted-warn ul li,
295 -div#mw-edit-semiprotectedpagewarning ul li,
296 -div#mw-edit-protectedpagewarning ul li {
 288+div.mw-warning-with-logexcerpt ul li {
297289 font-size: 90%;
298290 }
299291
Index: trunk/phase3/includes/Article.php
@@ -842,7 +842,7 @@
843843 $count = $pager->getNumRows();
844844 if( $count > 0 ) {
845845 $pager->mLimit = 10;
846 - $wgOut->addHtml( '<div id="mw-deleted-notice">' );
 846+ $wgOut->addHtml( '<div class="mw-warning-with-logexcerpt">' );
847847 $wgOut->addWikiMsg( 'deleted-notice' );
848848 $wgOut->addHTML(
849849 $loglist->beginLogEventsList() .
Index: trunk/phase3/includes/EditPage.php
@@ -1201,7 +1201,7 @@
12021202 $noticeMsg = 'protectedpagewarning';
12031203 $classes[] = 'mw-textarea-protected';
12041204 }
1205 - $wgOut->addHTML( "<div id='mw-edit-$noticeMsg'>\n" );
 1205+ $wgOut->addHTML( "<div class='mw-warning-with-logexcerpt'>\n" );
12061206 $wgOut->addWikiMsg( $noticeMsg );
12071207 LogEventsList::showLogExtract( $wgOut, 'protect', $this->mTitle->getPrefixedText(), '', 1 );
12081208 $wgOut->addHTML( "</div>\n" );
@@ -2344,7 +2344,7 @@
23452345 $count = $pager->getNumRows();
23462346 if ( $count > 0 ) {
23472347 $pager->mLimit = 10;
2348 - $out->addHtml( '<div id="mw-recreate-deleted-warn">' );
 2348+ $out->addHtml( '<div class="mw-warning-with-logexcerpt">' );
23492349 $out->addWikiMsg( 'recreate-deleted-warn' );
23502350 $out->addHTML(
23512351 $loglist->beginLogEventsList() .
Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -1735,7 +1735,7 @@
17361736 $loglist = new LogEventsList( $wgUser->getSkin(), $out );
17371737 $pager = new LogPager( $loglist, 'delete', false, $filename );
17381738 if( $pager->getNumRows() > 0 ) {
1739 - $out->addHtml( '<div id="mw-upload-deleted-warn">' );
 1739+ $out->addHtml( '<div class="mw-warning-with-logexcerpt">' );
17401740 $out->addWikiMsg( 'upload-wasdeleted' );
17411741 $out->addHTML(
17421742 $loglist->beginLogEventsList() .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41782* Format page protection warning identical to similar warnings...raymond21:16, 6 October 2008

Status & tagging log