r41702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41701‎ | r41702 | r41703 >
Date:19:21, 5 October 2008
Author:aaron
Status:old
Tags:
Comment:
Minor code cleanup
Modified paths:
  • /trunk/extensions/CodeReview/CodeRepository.php (modified) (history)
  • /trunk/extensions/CodeReview/CodeRevisionStatusSetter.php (modified) (history)
  • /trunk/extensions/CodeReview/CodeRevisionTagger.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRepository.php
@@ -24,7 +24,7 @@
2525
2626 static function newFromRow( $row ) {
2727 $repo = new CodeRepository();
28 - $repo->mId = $row->repo_id;
 28+ $repo->mId = intval($row->repo_id);
2929 $repo->mName = $row->repo_name;
3030 $repo->mPath = $row->repo_path;
3131 $repo->mViewVc = $row->repo_viewvc;
Index: trunk/extensions/CodeReview/CodeRevisionTagger.php
@@ -11,8 +11,6 @@
1212 }
1313
1414 function execute() {
15 - global $wgOut;
16 -
1715 if( $this->validPost( 'codereview-add-tag' ) ) {
1816 if( count($this->mAddTags) )
1917 $this->mRev->addTags( $this->mAddTags );
Index: trunk/extensions/CodeReview/CodeRevisionStatusSetter.php
@@ -10,14 +10,11 @@
1111 }
1212
1313 function execute() {
14 - global $wgOut;
15 -
1614 if( $this->validPost( 'codereview-set-status' ) ) {
1715 $this->mRev->setStatus( $this->mStatus );
1816
1917 $repo = $this->mRepo->getName();
2018 $rev = $this->mRev->getId();
21 - $special = SpecialPage::getTitleFor( 'Code', "$repo/$rev" );
2219 }
2320 }
2421

Status & tagging log