r41678 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41677‎ | r41678 | r41679 >
Date:23:40, 4 October 2008
Author:aaron
Status:old
Tags:
Comment:
* Reduce preview text size
* Link with focus to comments section. Would like to go to specific comment, but tablepager makes this awkward...
Modified paths:
  • /trunk/extensions/CodeReview/CodeCommentsListView.php (modified) (history)
  • /trunk/extensions/CodeReview/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeCommentsListView.php
@@ -68,7 +68,7 @@
6969 switch( $name ){
7070 case 'cc_rev_id':
7171 return $this->mView->mSkin->link(
72 - SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $value ),
 72+ SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $value . '#code-comments' ),
7373 htmlspecialchars( $value ) );
7474 case 'cr_status':
7575 return $this->mView->mSkin->link(
@@ -82,7 +82,7 @@
8383 case 'cc_text':
8484 # Truncate this, blah blah...
8585 $text = htmlspecialchars($value);
86 - $preview = $wgLang->truncate( $text, 400 );
 86+ $preview = $wgLang->truncate( $text, 300 );
8787 if( strlen($preview) < strlen($text) ) {
8888 $preview = substr( $preview, 0, strrpos($preview,' ') );
8989 $preview .= " . . .";
Index: trunk/extensions/CodeReview/CodeRevisionView.php
@@ -67,7 +67,7 @@
6868 "</div>\n";
6969 }
7070 $html .=
71 - "<h2>". wfMsgHtml( 'code-comments' ) ."</h2>\n" .
 71+ "<h2 id='code-comments'>". wfMsgHtml( 'code-comments' ) ."</h2>\n" .
7272 $this->formatComments();
7373
7474 if( $this->mReplyTarget ) {

Status & tagging log