r41667 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41666‎ | r41667 | r41668 >
Date:22:00, 4 October 2008
Author:aaron
Status:old
Tags:
Comment:
Make sure all RC entries for page are cleared on delete (bug 15655)
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2494,6 +2494,11 @@
24952495 if ( !$dbw->cleanupTriggers() ) {
24962496 # Clean up recentchanges entries...
24972497 $dbw->delete( 'recentchanges',
 2498+ array( 'rc_type != '.RC_LOG,
 2499+ 'rc_namespace' => $this->mTitle->getNamespace(),
 2500+ 'rc_title' => $this->mTitle->getDBKey() ),
 2501+ __METHOD__ );
 2502+ $dbw->delete( 'recentchanges',
24982503 array( 'rc_type != '.RC_LOG, 'rc_cur_id' => $id ),
24992504 __METHOD__ );
25002505 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41069Use cur_id condition alone so that it actually deletes the proper entries. (b...aaron14:19, 20 September 2008

Status & tagging log