r41533 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41532‎ | r41533 | r41534 >
Date:08:41, 2 October 2008
Author:mattj
Status:old
Tags:
Comment:
(bug 8440) Fix ipblocklist to show new allow usertalk flag.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialIpblocklist.php
@@ -292,7 +292,7 @@
293293 * Callback function to output a block
294294 */
295295 function formatRow( $block ) {
296 - global $wgUser, $wgLang;
 296+ global $wgUser, $wgLang, $wgBlockAllowsUTEdit;
297297
298298 wfProfileIn( __METHOD__ );
299299
@@ -303,7 +303,7 @@
304304 if( is_null( $msg ) ) {
305305 $msg = array();
306306 $keys = array( 'infiniteblock', 'expiringblock', 'unblocklink',
307 - 'anononlyblock', 'createaccountblock', 'noautoblockblock', 'emailblock' );
 307+ 'anononlyblock', 'createaccountblock', 'noautoblockblock', 'emailblock', 'nousertalk' );
308308 foreach( $keys as $key ) {
309309 $msg[$key] = wfMsgHtml( $key );
310310 }
@@ -341,6 +341,10 @@
342342 if ( $block->mBlockEmail && $block->mUser ) {
343343 $properties[] = $msg['emailblock'];
344344 }
 345+
 346+ if ( !$block->mAllowUsertalk && $wgBlockAllowsUTEdit ) {
 347+ $properties[] = $msg['nousertalk'];
 348+ }
345349
346350 $properties = implode( ', ', $properties );
347351
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2530,6 +2530,7 @@
25312531 'noautoblockblock' => 'autoblock disabled',
25322532 'createaccountblock' => 'account creation blocked',
25332533 'emailblock' => 'e-mail blocked',
 2534+'nousertalk' => 'cannot edit usertalk',
25342535 'ipblocklist-empty' => 'The blocklist is empty.',
25352536 'ipblocklist-no-results' => 'The requested IP address or username is not blocked.',
25362537 'blocklink' => 'block',

Follow-up revisions

RevisionCommit summaryAuthorDate
r41536(bug 8440) Add API support for new blocking flag, also fix defaults so anywhe...mattj09:34, 2 October 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41248(bug 8440) Allow preventing blocked users from editing their talk pages...mattj11:45, 25 September 2008
r41403Fix r41248 (bug 8440) - Default should be 1 to allow for previous behaviour t...mattj23:16, 29 September 2008

Status & tagging log