r41489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41488‎ | r41489 | r41490 >
Date:15:34, 1 October 2008
Author:mkroetzsch
Status:old
Tags:
Comment:
Language init done multiple times; remove obsolete second call
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php
@@ -231,7 +231,6 @@
232232 global $smwgIP, $wgHooks, $wgParser, $wgExtensionCredits, $smwgEnableTemplateSupport, $smwgMasterStore, $smwgIQRunningNumber, $wgLanguageCode, $wgVersion, $smwgToolboxBrowseLink;
233233
234234 $smwgMasterStore = NULL;
235 - smwfInitContentLanguage($wgLanguageCode); // this really could not be done in enableSemantics()
236235 wfLoadExtensionMessages('SemanticMediaWiki'); /// TODO: this is extremely slow; up to 10% of page display time (on a page with queries!) are consumed by loading unnecessary messages from a large file ...
237236 /// Past SMW releases had an average of about 1% extension loading time per call, while we are now up at 10%!
238237 /// (if no PHP caching is enabled, things become better with ACP but impact still is noticeable)
@@ -280,7 +279,7 @@
281280 /**
282281 * Register special classes for displaying semantic content on Property/Type pages
283282 */
284 -function smwfShowListPage (&$title, &$article){
 283+function smwfShowListPage(&$title, &$article){
285284 global $smwgIP;
286285 if ($title->getNamespace() == SMW_NS_TYPE){
287286 $article = new SMWTypePage($title);
@@ -350,10 +349,12 @@
351350 }
352351
353352 /**
354 - * Hook function for three tasks:
 353+ * Hook function for two tasks:
 354+ *
355355 * (1) insert HTML headers (CSS, JavaScript, and meta tags) into parser
356356 * output. This is our preferred method of working off the required scripts, since it
357357 * exploits parser caching.
 358+ *
358359 * (2) Fetch category information and other final settings from parser output.
359360 */
360361 function smwfParserAfterTidy(&$parser, &$text) {

Status & tagging log