r41462 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41461‎ | r41462 | r41463 >
Date:01:29, 1 October 2008
Author:brion
Status:old
Tags:
Comment:
Simplify ugly code a bit i noticed in r41411
Modified paths:
  • /trunk/extensions/intersection/DynamicPageList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/intersection/DynamicPageList.php
@@ -449,13 +449,15 @@
450450
451451 $query = array();
452452 if (true == $bShowCurId)
453 - $query = array( 'curid' => intval($row->page_id) );
 453+ $query['curid'] = intval($row->page_id);
454454
455455 if (true == $bShowNamespace)
456 - $output .= $sk->link($title, htmlspecialchars($title->getPrefixedText()), array(), $query, array( 'forcearticlepath', 'known' ) );
 456+ $titleText = $title->getPrefixedText();
457457 else
458 - $output .= $sk->link($title, htmlspecialchars($title->getText()), array(), $query, array( 'forcearticlepath', 'known' ) );
 458+ $titleText = $title->getText();
459459
 460+ $output .= $sk->link($title, htmlspecialchars($titleText), array(), $query, array( 'forcearticlepath', 'known' ) );
 461+
460462 $output .= $sEndItem . "\n";
461463 }
462464

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41411Update showcurid feature to use article path. Also update to use new link fun...mattj02:01, 30 September 2008

Status & tagging log