r41397 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41396‎ | r41397 | r41398 >
Date:16:22, 29 September 2008
Author:mkroetzsch
Status:old
Tags:
Comment:
remove undelete hook; linkUpdate hook takes care of this too
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_Hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/SMW_Hooks.php
@@ -277,17 +277,6 @@
278278 }
279279
280280 /**
281 -* Restore semantic data if articles are undeleted.
282 -*/
283 -function smwfUndeleteHook(&$title, $create) {
284 - if ($create) {
285 - SMWFactbox::setNewArticle();
286 - }
287 - SMWFactbox::storeData(smwfIsSemanticsProcessed($title->getNamespace()));
288 - return true; // always return true, in order not to stop MW's hook processing!
289 -}
290 -
291 -/**
292281 * This method will be called whenever an article is deleted so that
293282 * semantic properties are cleared appropriately.
294283 */
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_GlobalFunctions.php
@@ -246,7 +246,6 @@
247247
248248 $wgHooks['InternalParseBeforeLinks'][] = 'smwfParserHook'; // parse annotations
249249 $wgHooks['ArticleSave'][] = 'smwfPreSaveHook'; // check some settings here
250 - $wgHooks['ArticleUndelete'][] = 'smwfUndeleteHook'; // restore annotations
251250 $wgHooks['ArticleDelete'][] = 'smwfDeleteHook'; // delete annotations
252251 $wgHooks['TitleMoveComplete'][]='smwfMoveHook'; // move annotations
253252 $wgHooks['ParserAfterTidy'][] = 'smwfParserAfterTidy'; // add items to HTML header during parsing

Status & tagging log