r41290 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41289‎ | r41290 | r41291 >
Date:18:47, 26 September 2008
Author:aaron
Status:old
Tags:
Comment:
Remove filecache check per r41274
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -261,7 +261,7 @@
262262 #########
263263
264264 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
265 -$wgFlaggedRevStyleVersion = 40;
 265+$wgFlaggedRevStyleVersion = 41;
266266
267267 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
268268
@@ -408,9 +408,6 @@
409409 $wgHooks['PageHistoryBeforeList'][] = 'FlaggedRevsHooks::injectStyleAndJS';
410410 $wgHooks['BeforePageDisplay'][] = 'FlaggedRevsHooks::InjectStyleForSpecial';
411411
412 -# File cache
413 -$wgHooks['IsFileCacheable'][] = 'FlaggedRevsHooks::isFileCacheable';
414 -
415412 # Cache updates
416413 $wgHooks['HTMLCacheUpdate::doUpdate'][] = 'FlaggedRevsHooks::doCacheUpdate';
417414
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -1240,19 +1240,6 @@
12411241 }
12421242 return true;
12431243 }
1244 -
1245 - public static function isFileCacheable( &$article ) {
1246 - $fa = FlaggedArticle::getInstance( $article );
1247 - # If the stable is the default, and we are viewing it...cache it!
1248 - if( $fa->isReviewable() && $fa->showStableByDefault() ) {
1249 - return ( $fa->pageOverride() && $fa->getStableRev() );
1250 - # If the draft is the default, and we are viewing it...cache it!
1251 - } else {
1252 - global $wgRequest;
1253 - # We don't want to cache the pending edit notice though
1254 - return !$wgRequest->getVal('shownotice') && !( $fa->pageOverride() && $fa->getStableRev() );
1255 - }
1256 - }
12571244
12581245 public static function onParserTestTables( &$tables ) {
12591246 $tables[] = 'flaggedpages';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41274FileCache cleanup:...aaron23:02, 25 September 2008