r41237 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41236‎ | r41237 | r41238 >
Date:19:00, 24 September 2008
Author:dale
Status:old
Tags:
Comment:
removed annodex based urls in favor of oggzchop urls, updated to oggz r3725 on mediaServer
Modified paths:
  • /trunk/extensions/MetavidWiki/includes/MV_Title.php (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/README (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_data_proxy.php (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js (modified) (history)
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_playlist.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/includes/MV_Title.php
@@ -283,7 +283,8 @@
284284 if ( $this->getStartTime() != '' && $this->getEndTime() != '' ) {
285285 if ( $quality == $mvDefaultVideoQualityKey ||
286286 $quality == $mvDefaultVideoHighQualityKey ) {
287 - $time_req = '.anx?t=' . $this->getStartTime() . '/' . $this->getEndTime();
 287+ //removed .anx
 288+ $time_req = '?t=' . $this->getStartTime() . '/' . $this->getEndTime();
288289 } else if ( $quality == $mvDefaultFlashQualityKey ) {
289290 $time_req = '?t=' . $this->getStartTime() . '/' . $this->getEndTime();
290291 }
Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js
@@ -26,9 +26,6 @@
2727 //note: this is necessary for remote embedding because of java security model)
2828 var mv_java_iframe = true;
2929
30 -//ogg chop links ( removes .anx from stream) should be deprecated shortly
31 -var ogg_chop_links = true;
32 -
3330 //media_server mv_embed_path (the path on media servers to mv_embed for java iframe with leading and trailing slashes)
3431 var mv_media_iframe_path = '/mv_embed/';
3532
@@ -78,7 +75,7 @@
7976
8077 gMsg['error_swap_vid']='Error:mv_embed was unable to swap the video tag for the mv_embed interface';
8178
82 -gMsg['download_from']='Download Selection:';
 79+gMsg['download_segment']='Download Selection:';
8380 gMsg['download_full']='Download Full Video File:'
8481 gMsg['download_clip']='Download the Clip';
8582 gMsg['download_text']='Download Text (<a style="color:white" title="cmml" href="http://wiki.xiph.org/index.php/CMML">cmml</a> xml):';
@@ -1244,9 +1241,7 @@
12451242 }
12461243 },
12471244 show:function(){
1248 - //js_log("show text interface");
1249 - /*fade out cc button*/
1250 - $j('#metaButton_'+this.pe.id).fadeOut('fast');
 1245+ js_log("f:show() text interface");
12511246 /*slide in intefrace container*/
12521247 //dont' know how 'px' creeps in here:
12531248 this.pe.height = this.pe.height.replace('px', '');
@@ -1414,11 +1409,9 @@
14151410
14161411 init : function(element)
14171412 {
1418 - js_log(element);
 1413+ js_log('adding mediaSource: ' + element);
14191414
1420 - this.src = $j(element).attr('src');
1421 - if(ogg_chop_links)
1422 - this.src = this.src.replace(".anx", '');
 1415+ this.src = $j(element).attr('src');
14231416
14241417 this.marked_default = false;
14251418
@@ -1457,6 +1450,11 @@
14581451 //js_log('Adding mediaSource of type ' + this.mime_type + ' and uri ' + this.src + ' and title ' + this.title);
14591452 this.parseURLDuration();
14601453 },
 1454+ updateSource:function(element){
 1455+ //for now just update the title:
 1456+ if ($j(element).attr("title"))
 1457+ this.title = $j(element).attr("title");
 1458+ },
14611459 /** updates the src time and start & end
14621460 * @param {String} start_time in NTP format
14631461 * @param {String} end_time in NTP format
@@ -1733,8 +1731,11 @@
17341732 }
17351733 var new_src = $j(element).attr('src');
17361734 //make sure an existing element with the same src does not already exist:
1737 - for(i in this.sources){
1738 - if(this.sources[i].getURI()==new_src){
 1735+ for(i in this.sources){
 1736+ if(this.sources[i].getURI()==new_src){
 1737+ js_log('checking existing: '+this.sources[i].getURI() + ' != '+ new_src);
 1738+ //can't add it all but try to update any additional attr:
 1739+ this.sources[i].updateSource(element);
17391740 return false;
17401741 }
17411742 }
@@ -2619,7 +2620,7 @@
26202621 }
26212622 }
26222623 select_html+='</ul></div>';
2623 - js_log(select_html);
 2624+ //js_log(select_html);
26242625 return select_html;
26252626 },
26262627 selectPlaybackMethod:function(){
@@ -2670,10 +2671,11 @@
26712672 }
26722673 },
26732674 getShowVideoDownload:function(){
2674 - var out='<b style="color:white;">'+getMsg('download_from')+'</b><br>';
 2675+ var out='<b style="color:white;">'+getMsg('download_segment')+'</b><br>';
26752676 out+='<span style="color:white"><blockquote>';
26762677 var dl_list='';
26772678 var dl_txt_list='';
 2679+
26782680 $j.each(this.media_element.getSources(), function(index, source){
26792681 var dl_line = '<li>' + '<a style="color:white" href="' + source.getURI() +'"> '
26802682 + source.getTitle()+'</a> '+ '</li>'+"\n";
@@ -2942,7 +2944,7 @@
29432945 //add json_ to req url
29442946 if(req_url.indexOf("feed_format=")!=-1)
29452947 req_url = req_url.replace(/feed_format=/, 'feed_format=json_');
2946 - js_log('json url: '+ req_url);
 2948+ //js_log('json url: '+ req_url);
29472949 //response type is mv_json_response or proxy dissabled
29482950 loadExternalJs(req_url+'&cb=mv_jsdata_cb&cb_inx='+(global_req_cb.length-1));
29492951 }
Index: trunk/extensions/MetavidWiki/skins/mv_embed/README
@@ -1,6 +1,6 @@
22 ***********************************************
33 *
4 -* mv_embed version .6
 4+* mv_embed version 1.0rc1
55 * for details see: http://metavid.ucsc.edu/wiki/index.php/Mv_embed
66 * and this README
77 *
@@ -16,7 +16,6 @@
1717 v.7
1818
1919
20 -
2120 v.6
2221 * added msg system for compatibility with translations
2322 * add support for relative file or path names for media files for cortado.
Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_data_proxy.php
@@ -7,7 +7,7 @@
88 * (so that remote use of mv_embed can load remote xml )
99 */
1010
11 -// NOTE THIS IS DISABLED BY DEFAULT FOR A RESON
 11+// NOTE THIS IS DISABLED BY DEFAULT FOR A REASON
1212 // See var mv_data_proxy in mv_embed.js for more info
1313 die( 'note mv_data_proxy is disabled by default' );
1414
Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_playlist.js
@@ -1679,11 +1679,11 @@
16801680 $j('#'+tObj.overlay_selector_id).show();
16811681
16821682 //do update:
1683 - js_log('doing update for: '+ tObj.pClip.id +
 1683+ /*js_log('doing update for: '+ tObj.pClip.id +
16841684 ' type:' + tObj.transAttrType +
16851685 ' t_type:'+ tObj.type +
16861686 ' subypte:'+ tObj.subtype +
1687 - ' percent:' + percent);
 1687+ ' percent:' + percent);*/
16881688
16891689 this['type'][tObj.type][tObj.subtype].u(tObj,percent);
16901690 },

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r3725Remove redundant options arrayvibber21:30, 28 May 2004