r41231 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41230‎ | r41231 | r41232 >
Date:17:28, 24 September 2008
Author:aaron
Status:old
Tags:
Comment:
Another fix for r41086. Don't keep retrying server if connection fails.
Modified paths:
  • /trunk/phase3/includes/ExternalStore.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalStore.php
@@ -92,12 +92,12 @@
9393 $url = $store->store( $params, $data ); // Try to save the object
9494 } catch ( DBConnectionError $error ) {
9595 $url = false;
96 - unset( $tryStores[$index] ); // Don't try this one again!
97 - $tryStores = array_values( $tryStores ); // Must have consecutive keys
9896 }
9997 if ( $url ) {
10098 return $url; // Done!
10199 } else {
 100+ unset( $tryStores[$index] ); // Don't try this one again!
 101+ $tryStores = array_values( $tryStores ); // Must have consecutive keys
102102 wfDebugLog( 'ExternalStorage', "Unable to store text to external storage $storeUrl" );
103103 }
104104 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r41234Revert some recent ES-related changes -- they made behavior much worse when w...brion18:09, 24 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41086Revert/rewrite of r40696....tstarling06:42, 21 September 2008