r41229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r41228‎ | r41229 | r41230 >
Date:16:09, 24 September 2008
Author:aaron
Status:old
Tags:
Comment:
Revert untested code change from r41086. Don't call methods on non-objects, the fatal will stop even with the error catching.
Modified paths:
  • /trunk/phase3/includes/ExternalStoreDB.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalStoreDB.php
——@@ -123,7 +123,9 @@
124124 */
125125 function store( $cluster, $data ) {
126126 $dbw = $this->getMaster( $cluster );
127 -
 127+ #if( !$dbw ) {
 128+ # return false;
 129+ #}
128130 $id = $dbw->nextSequenceValue( 'blob_blob_id_seq' );
129131 $dbw->insert( $this->getTable( $dbw ),
130132 array( 'blob_id' => $id, 'blob_text' => $data ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r41234Revert some recent ES-related changes -- they made behavior much worse when w...brion18:09, 24 September 2008
r41329* Revert revert r41234 of ES-related changes. The site_stats complaint should...tstarling01:42, 28 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41086Revert/rewrite of r40696....tstarling06:42, 21 September 2008