r41160 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41159‎ | r41160 | r41161 >
Date:16:16, 22 September 2008
Author:raymond
Status:old
Tags:
Comment:
Add a link to edit the proction reason list
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)
  • /trunk/phase3/skins/common/common_rtl.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/modern/rtl.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)
  • /trunk/phase3/skins/simple/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1569,6 +1569,7 @@
15701570 'protect-otherreason',
15711571 'protect-otherreason-op',
15721572 'protect-dropdown',
 1573+ 'protect-edit-reasonlist',
15731574 'restriction-type',
15741575 'restriction-level',
15751576 'minimum-size',
Index: trunk/phase3/skins/monobook/rtl.css
@@ -205,8 +205,9 @@
206206 float: right;
207207 margin: 0 0 1em 3em;
208208 }
209 -/* Convenience links to edit block and delete reasons */
210 -p.mw-ipb-conveniencelinks, p.mw-filedelete-editreasons, p.mw-delete-editreasons {
 209+/* Convenience links to edit block, delete and protect reasons */
 210+p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
 211+p.mw-filedelete-editreasons, p.mw-delete-editreasons {
211212 float: left;
212213 }
213214
Index: trunk/phase3/skins/modern/rtl.css
@@ -82,8 +82,9 @@
8383 float: right;
8484 margin: 0 0 1em 3em;
8585 }
86 -/* Convenience links to edit block and delete reasons */
87 -p.mw-ipb-conveniencelinks, p.mw-filedelete-editreasons, p.mw-delete-editreasons {
 86+/* Convenience links to edit block, delete and protect reasons */
 87+p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
 88+p.mw-filedelete-editreasons, p.mw-delete-editreasons {
8889 float: left;
8990 }
9091
Index: trunk/phase3/skins/common/shared.css
@@ -92,8 +92,9 @@
9393 .mw-hidden-cats-hidden { display: none; }
9494 .catlinks-allhidden { display: none; }
9595
96 -/* Convenience links to edit block and delete reasons */
97 -p.mw-ipb-conveniencelinks, p.mw-filedelete-editreasons, p.mw-delete-editreasons {
 96+/* Convenience links to edit block, delete and protect reasons */
 97+p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
 98+p.mw-filedelete-editreasons, p.mw-delete-editreasons {
9899 font-size: 90%;
99100 float: right;
100101 }
Index: trunk/phase3/skins/common/common_rtl.css
@@ -28,8 +28,9 @@
2929 div.tleft, div.floatleft {
3030 clear: left;
3131 }
32 -/* Convenience links to edit block and delete reasons */
33 -p.mw-ipb-conveniencelinks, p.mw-filedelete-editreasons, p.mw-delete-editreasons {
 32+/* Convenience links to edit block, delete and protect reasons */
 33+p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
 34+p.mw-filedelete-editreasons, p.mw-delete-editreasons {
3435 float: left;
3536 }
3637 table.filehistory th {
Index: trunk/phase3/skins/simple/rtl.css
@@ -151,8 +151,9 @@
152152 float: right;
153153 margin: 0 0 1em 3em;
154154 }
155 -/* Convenience links to edit block and delete reasons */
156 -p.mw-ipb-conveniencelinks, p.mw-filedelete-editreasons, p.mw-delete-editreasons {
 155+/* Convenience links to edit block, delete and protect reasons */
 156+p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
 157+p.mw-filedelete-editreasons, p.mw-delete-editreasons {
157158 float: left;
158159 }
159160
Index: trunk/phase3/includes/ProtectionForm.php
@@ -436,6 +436,12 @@
437437 }
438438 $out .= Xml::closeElement( 'fieldset' );
439439
 440+ if ( $wgUser->isAllowed( 'editinterface' ) ) {
 441+ $linkTitle = Title::makeTitleSafe( NS_MEDIAWIKI, 'protect-dropdown' );
 442+ $link = $wgUser->getSkin()->Link ( $linkTitle, wfMsgHtml( 'protect-edit-reasonlist' ) );
 443+ $out .= '<p class="mw-protect-editreasons">' . $link . '</p>';
 444+ }
 445+
440446 if ( !$this->disabled ) {
441447 $out .= Xml::closeElement( 'form' ) .
442448 $this->buildCleanupScript();
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1375,7 +1375,7 @@
13761376 * to ensure that client-side caches don't keep obsolete copies of global
13771377 * styles.
13781378 */
1379 -$wgStyleVersion = '178';
 1379+$wgStyleVersion = '179';
13801380
13811381
13821382 # Server-side caching:
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2346,6 +2346,7 @@
23472347 ** Excessive spamming
23482348 ** Counter-productive edit warring
23492349 ** High traffic page',
 2350+'protect-edit-reasonlist' => 'Edit protection reasons',
23502351 'restriction-type' => 'Permission:',
23512352 'restriction-level' => 'Restriction level:',
23522353 'minimum-size' => 'Min size',