r41140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41139‎ | r41140 | r41141 >
Date:06:28, 22 September 2008
Author:werdna
Status:old
Tags:
Comment:
Make some obscure options actually useful, and mark some as obsolete.
Modified paths:
  • /trunk/extensions/AbuseFilter/AbuseFilter.class.php (modified) (history)
  • /trunk/extensions/AbuseFilter/AbuseFilter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/AbuseFilter.php
@@ -54,7 +54,8 @@
5555 $wgAbuseFilterAvailableActions = array( 'flag', 'throttle', 'warn', 'disallow', 'blockautopromote', 'block', 'degroup', 'rangeblock' );
5656
5757 // Conditions take about 4ms to check, so 100 conditions would take 400ms
58 -$wgAbuseFilterConditionLimit = 1000;
 58+// Currently, has no effect.
 59+// $wgAbuseFilterConditionLimit = 1000;
5960
6061 // Disable filters if they match more than X edits, constituting more than Y% of the last Z edits, if they have been changed in the last S seconds
6162 $wgAbuseFilterEmergencyDisableThreshold = 0.50;
Index: trunk/extensions/AbuseFilter/AbuseFilter.class.php
@@ -235,7 +235,7 @@
236236
237237 // Threaten them a little bit
238238 if (strlen($parameters[0])) {
239 - $display .= call_user_func_array( 'wfMsgNoTrans', $parameters ) . "\n";
 239+ $display .= wfMsgNoTrans( $parameters[0], $rule_desc ) . "\n";
240240 } else {
241241 // Generic message.
242242 $display .= wfMsgNoTrans( 'abusefilter-warning', $rule_desc ) ."<br />\n";
@@ -253,7 +253,7 @@
254254
255255 // Don't let them do it
256256 if (strlen($parameters[0])) {
257 - $display .= call_user_func_array( 'wfMsgNoTrans', $parameters ) . "\n";
 257+ $display .= wfMsgNoTrans( $parameters[0], $rule_desc ) . "\n";
258258 } else {
259259 // Generic message.
260260 $display .= wfMsgNoTrans( 'abusefilter-disallowed', $rule_desc ) ."<br />\n";