r41080 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41079‎ | r41080 | r41081 >
Date:22:31, 20 September 2008
Author:david
Status:old
Tags:
Comment:
(bug 15606) Respect wgDBTableOptions. Tell users to use sql.php in the README.
Modified paths:
  • /trunk/extensions/LiquidThreads/README (modified) (history)
  • /trunk/extensions/LiquidThreads/lqt.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/README
@@ -10,8 +10,15 @@
1111
1212 1. Rename this directory to extensions/LiquidThreads inside your
1313 MediaWiki directory.
14 -2. Cause your MySQL server to execute the statements in lqt.sql.
15 - (On Unix, you can say, "mysql -u $USER -p -e 'source lqt.sql'".)
 14+2. Add database tables from lqt.sql using the sql.php MediaWiki tool.
 15+ (On Unix, if the current directory is the MediaWiki root directory, you can
 16+ say "php maintenance/sql.php extensions/LiquidThreads/lqt.sql".)
 17+ If you haven't created the AdminSettings.php file, you will have to do that
 18+ first; see http://www.mediawiki.org/wiki/Manual:AdminSettings.php
 19+ Alternatively, you can run lqt.sql manually (you can use the command
 20+ "mysql -u $USER -p -e 'source lqt.sql'" on Unix), but you might have to
 21+ edit it first, and replace the /*$wgDBprefix*/ and /*$wgDBTableOptions*/
 22+ strings with the corresponding settings.
1623 3. Add this line to the end of your LocalSettings.php:
1724 require_once('extensions/LiquidThreads/LiquidThreads.php');
1825
Index: trunk/extensions/LiquidThreads/lqt.sql
@@ -30,7 +30,7 @@
3131 INDEX thread_modified (thread_modified),
3232 INDEX thread_created (thread_created),
3333 INDEX thread_summary_page (thread_summary_page)
34 -) TYPE=InnoDB;
 34+) /*$wgDBTableOptions*/;
3535
3636 CREATE TABLE /*$wgDBprefix*/historical_thread (
3737 -- Note that many hthreads can share an id, which is the same as the id
@@ -41,7 +41,7 @@
4242 hthread_change_type int(4) unsigned NOT NULL,
4343 hthread_change_object int(8) unsigned NULL,
4444 PRIMARY KEY hthread_id_revision (hthread_id, hthread_revision)
45 -) TYPE=InnoDB;
 45+) /*$wgDBTableOptions*/;
4646
4747 CREATE TABLE /*$wgDBprefix*/user_message_state (
4848 ums_user int unsigned NOT NULL,
@@ -49,4 +49,4 @@
5050 ums_read_timestamp varbinary(14),
5151
5252 PRIMARY KEY (ums_user, ums_thread)
53 -) TYPE=InnoDB;
 53+) /*$wgDBTableOptions*/;