r41071 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41070‎ | r41071 | r41072 >
Date:14:37, 20 September 2008
Author:aaron
Status:old
Tags:
Comment:
Remove unnecessary transaction
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1554,8 +1554,6 @@
15551555 $this->mGoodAdjustment = (int)$this->isCountable( $text );
15561556 $this->mTotalAdjustment = 1;
15571557
1558 - $dbw->begin();
1559 -
15601558 # Add the page record; stake our claim on this title!
15611559 # This will fail with a database query exception if the article already exists
15621560 $newid = $this->insertOn( $dbw );
@@ -1587,7 +1585,6 @@
15881586 }
15891587 }
15901588 $user->incEditCount();
1591 - $dbw->commit();
15921589
15931590 # Update links, etc.
15941591 $this->editUpdates( $text, $summary, $isminor, $now, $revisionId, true );