r41063 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41062‎ | r41063 | r41064 >
Date:08:40, 20 September 2008
Author:aaron
Status:old
Tags:
Comment:
Use normal, more patient, connection attempts for master connection here
Modified paths:
  • /trunk/phase3/includes/ExternalStoreDB.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalStoreDB.php
@@ -41,9 +41,7 @@
4242 /** @todo Document.*/
4343 function &getMaster( $cluster, $retry = true ) {
4444 $lb =& $this->getLoadBalancer( $cluster );
45 - // Make only two connection attempts if there are other clusters to try
46 - $attempts = $retry ? false : 2;
47 - return $lb->getConnection( DB_MASTER, array(), false, $attempts, LoadBalancer::GRACEFUL );
 45+ return $lb->getConnection( DB_MASTER, array(), false, false, LoadBalancer::GRACEFUL );
4846 }
4947
5048 /** @todo Document.*/

Follow-up revisions

RevisionCommit summaryAuthorDate
r41234Revert some recent ES-related changes -- they made behavior much worse when w...brion18:09, 24 September 2008