r41036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r41035‎ | r41036 | r41037 >
Date:16:43, 19 September 2008
Author:yaron
Status:old
Tags:
Comment:
Fixed accidental overriding of 'size' param in form definitions
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.inc
@@ -1174,7 +1174,8 @@
11751175 // set field to be a list if that was specified in the form definition
11761176 if ($form_field->is_list) {
11771177 $other_args['is_list'] = true;
1178 - $other_args['size'] = 100;
 1178+ if (! array_key_exists('size', $other_args))
 1179+ $other_args['size'] = 100;
11791180 }
11801181 if ($form_field->possible_values != null)
11811182 $other_args['possible_values'] = $form_field->possible_values;

Status & tagging log