r40944 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40943‎ | r40944 | r40945 >
Date:02:50, 17 September 2008
Author:soxred93
Status:old
Tags:
Comment:
Readding 'Full Block Log' link, after being removed for not using Linker function.
Patch submitted by Matt Johnston, in bug 14638
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBlockip.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -395,6 +395,7 @@
396396 } else {
397397 $out->addWikiMsg( 'logempty' );
398398 }
 399+ return $pager->getNumRows();
399400 }
400401
401402 /**
Index: trunk/phase3/includes/specials/SpecialBlockip.php
@@ -418,8 +418,12 @@
419419 }
420420
421421 function showLogFragment( $out, $title ) {
 422+ global $wgUser;
422423 $out->addHtml( Xml::element( 'h2', NULL, LogPage::logName( 'block' ) ) );
423 - LogEventsList::showLogExtract( $out, 'block', $title->getPrefixedText() );
 424+ $count = LogEventsList::showLogExtract( $out, 'block', $title->getPrefixedText(), '', 10 );
 425+ if($count > 10){
 426+ $out->addHtml( $wgUser->getSkin()->link(Title::newFromText('Special:Log/block'), wfMsg('blocklog-fulllog'), array(), array('type' => 'block', 'page' => $title->getPrefixedText()), array('known') ) );
 427+ }
424428 }
425429
426430 /**
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2520,6 +2520,7 @@
25212521 'autoblocker' => 'Autoblocked because your IP address has been recently used by "[[User:$1|$1]]".
25222522 The reason given for $1\'s block is: "$2"',
25232523 'blocklogpage' => 'Block log',
 2524+'blocklog-fulllog' => 'Full block log',
25242525 'blocklogentry' => 'blocked [[$1]] with an expiry time of $2 $3',
25252526 'blocklogtext' => 'This is a log of user blocking and unblocking actions.
25262527 Automatically blocked IP addresses are not listed.
Index: trunk/phase3/RELEASE-NOTES
@@ -207,6 +207,7 @@
208208 * (bug 15598) Special:Newpages default limit uses user preference for recentchanges
209209 limit instead of hardcoded 50.
210210 * (bug 15617) $wgFeedClassesOutputPage::getHeadLinks() respects $wgFeedClasses, instead of hardcoding rss and atom. Patch by Juliano F. Ravasi.
 211+* (bug 14638) Special:Blockip now provides a link to the block log if the user has been blocked more than 10 times. Patch by Matt Johnston.
211212
212213 === API changes in 1.14 ===
213214

Follow-up revisions

RevisionCommit summaryAuthorDate
r40995Cleanup for r40944:...brion17:01, 18 September 2008
r41131(Bug 15650) Limit length of displayed deletion log while creating a new page...mattj20:25, 21 September 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r40838(bug 14638)...soxred9301:26, 15 September 2008