r40816 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40815‎ | r40816 | r40817 >
Date:12:25, 14 September 2008
Author:aaron
Status:old
Tags:
Comment:
Don't throw fatals for bogus feed types (bug 15596)
Modified paths:
  • /trunk/phase3/includes/ChangesFeed.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesFeed.php
@@ -12,7 +12,8 @@
1313 public function getFeedObject( $title, $description ) {
1414 global $wgSitename, $wgContLanguageCode, $wgFeedClasses, $wgTitle;
1515 $feedTitle = "$wgSitename - {$title} [$wgContLanguageCode]";
16 -
 16+ if( !isset($wgFeedClasses[$this->format] ) )
 17+ return false;
1718 return new $wgFeedClasses[$this->format](
1819 $feedTitle, htmlspecialchars( $description ), $wgTitle->getFullUrl() );
1920 }