r40793 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40792‎ | r40793 | r40794 >
Date:18:18, 13 September 2008
Author:siebrand
Status:old
Tags:
Comment:
Add plural support for 'smw_typearticlecount', 'smw_attributearticlecount', 'smw_subpropertyarticlecount', and 'smw_conceptarticlecount'
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_ConceptPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_PropertyPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_TypePage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/languages/SMW_Messages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_ConceptPage.php
@@ -78,7 +78,7 @@
7979 $r .= '<a name="SMWResults"></a>' . $nav . "<div id=\"mw-pages\">\n";
8080
8181 $r .= '<h2>' . wfMsg('smw_concept_header',$ti) . "</h2>\n";
82 - $r .= wfMsg('smw_conceptarticlecount', min($this->limit, count($this->articles))) . smwfEncodeMessages($this->m_errors) . "\n";
 82+ $r .= wfMsgExt('smw_conceptarticlecount', array( 'parsemag' ), min($this->limit, count($this->articles))) . smwfEncodeMessages($this->m_errors) . "\n";
8383
8484 $r .= $this->formatList();
8585 $r .= "\n</div>" . $nav;
Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_TypePage.php
@@ -74,7 +74,7 @@
7575 $r .= '<a name="SMWResults"></a>' . $nav . "<div id=\"mw-pages\">\n";
7676
7777 $r .= '<h2>' . wfMsg('smw_type_header',$ti) . "</h2>\n";
78 - $r .= wfMsg('smw_typearticlecount', min($this->limit, count($this->articles))) . "\n";
 78+ $r .= wfMsgExt('smw_typearticlecount', array( 'parsemag' ), min($this->limit, count($this->articles))) . "\n";
7979
8080 $r .= $this->formatList();
8181 $r .= "\n</div>" . $nav;
Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_PropertyPage.php
@@ -88,7 +88,7 @@
8989 $nav = $this->getNavigationLinks();
9090 if (count($this->subproperties) > 0) {
9191 $r .= "<div id=\"mw-subcategories\">\n<h2>" . wfMsg('smw_subproperty_header',$ti) . "</h2>\n";
92 - $r .= '<p>' . wfMsg('smw_subpropertyarticlecount', min($this->limit, count($this->subproperties))) . "</p>\n";
 92+ $r .= '<p>' . wfMsgExt('smw_subpropertyarticlecount', array( 'parsemag' ), min($this->limit, count($this->subproperties))) . "</p>\n";
9393 if (count($this->subproperties) < 6) {
9494 $r .= $this->shortList(0,count($this->subproperties), $this->subproperties);
9595 } else {
@@ -98,7 +98,7 @@
9999 }
100100 $r .= '<a name="SMWResults"></a>' . $nav . "<div id=\"mw-pages\">\n";
101101 $r .= '<h2>' . wfMsg('smw_attribute_header',$ti) . "</h2>\n";
102 - $r .= '<p>' . wfMsg('smw_attributearticlecount', min($this->limit, count($this->articles))) . "</p>\n";
 102+ $r .= '<p>' . wfMsgExt('smw_attributearticlecount', array( 'parsemag' ), min($this->limit, count($this->articles))) . "</p>\n";
103103 $r .= $this->subjectObjectList() . "\n</div>" . $nav;
104104 }
105105 wfProfileOut( __METHOD__ . ' (SMW)');
Index: trunk/extensions/SemanticMediaWiki/languages/SMW_Messages.php
@@ -113,13 +113,13 @@
114114
115115 // Messages for pages of types and properties
116116 'smw_type_header' => 'Properties of type "$1"',
117 - 'smw_typearticlecount' => 'Showing $1 properties using this type.',
 117+ 'smw_typearticlecount' => 'Showing $1 {{PLURAL:$1|property|properties}} using this type.',
118118 'smw_attribute_header' => 'Pages using the property "$1"',
119 - 'smw_attributearticlecount' => 'Showing $1 pages using this property.',
 119+ 'smw_attributearticlecount' => 'Showing $1 {{PLURAL:$1|page|pages}} using this property.',
120120 'smw_subproperty_header' => 'Subproperties',
121 - 'smw_subpropertyarticlecount' => 'This property has the following $1 subproperties.',
 121+ 'smw_subpropertyarticlecount' => 'This property has the following $1 {{PLURAL:$1|subproperty|subproperties}}.',
122122 'smw_concept_header' => 'Pages of concept "$1"',
123 - 'smw_conceptarticlecount' => 'Showing $1 pages belonging to that concept.',
 123+ 'smw_conceptarticlecount' => 'Showing $1 {{PLURAL:$1|page|pages}} belonging to that concept.',
124124
125125 // Messages used in RSS feeds
126126 'smw_rss_description' => '$1 RSS feed',

Status & tagging log