r40773 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40772‎ | r40773 | r40774 >
Date:06:27, 13 September 2008
Author:soxred93
Status:old
Tags:
Comment:
(bug 12284) Special:Preferences now sets a returnto parameter on the link to Special:Userlogin.
Patch by Marooned.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -45,6 +45,7 @@
4646 * Jeremy Baron
4747 * Juliano F. Ravasi
4848 * Louperivois
 49+* Marooned
4950 * Matt Johnston
5051 * Max Semenik
5152 * Michael De La Rue
Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -104,10 +104,10 @@
105105 }
106106
107107 function execute() {
108 - global $wgUser, $wgOut;
 108+ global $wgUser, $wgOut, $wgTitle;
109109
110110 if ( $wgUser->isAnon() ) {
111 - $wgOut->showErrorPage( 'prefsnologin', 'prefsnologintext' );
 111+ $wgOut->showErrorPage( 'prefsnologin', 'prefsnologintext', array($wgTitle->getPrefixedDBkey()) );
112112 return;
113113 }
114114 if ( wfReadOnly() ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1467,7 +1467,7 @@
14681468 'mypreferences' => 'My preferences',
14691469 'prefs-edits' => 'Number of edits:',
14701470 'prefsnologin' => 'Not logged in',
1471 -'prefsnologintext' => 'You must be [[Special:UserLogin|logged in]] to set user preferences.',
 1471+'prefsnologintext' => 'You must be <span class="plainlinks">[{{fullurl:Special:Userlogin|returnto=$1}} logged in]</span> to set user preferences.',
14721472 'prefsreset' => 'Preferences have been reset from storage.',
14731473 'qbsettings' => 'Quickbar',
14741474 'qbsettings-none' => 'None',
Index: trunk/phase3/RELEASE-NOTES
@@ -196,6 +196,7 @@
197197 * (bug 15497) Removed encoding attribute from <?xml ?> tag
198198 * (bug 15544) Wiki not set up message (NoLocalSettings.php) now works for
199199 non-index.php entry pages (e.g. api.php). Patch by Matt Johnston.
 200+* (bug 12284) Special:Preferences now sets a returnto parameter on the link to Special:Userlogin. Patch by Marooned.
200201
201202
202203 === API changes in 1.14 ===