r40766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40765‎ | r40766 | r40767 >
Date:22:26, 12 September 2008
Author:btongminh
Status:old
Tags:
Comment:
Don't access $_SESSION in UploadBase::stashSession.
Modified paths:
  • /trunk/phase3/includes/UploadBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UploadBase.php
@@ -370,14 +370,12 @@
371371 return false;
372372 }
373373
374 - $key = mt_rand( 0, 0x7fffffff );
375 - $_SESSION['wsUploadData'][$key] = array(
 374+ return array(
376375 'mTempPath' => $status->value,
377376 'mFileSize' => $this->mFileSize,
378377 'mFileProps' => $this->mFileProps,
379378 'version' => self::SESSION_VERSION,
380379 );
381 - return $key;
382380 }
383381
384382 /**