r40756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40755‎ | r40756 | r40757 >
Date:17:01, 12 September 2008
Author:aaron
Status:old
Tags:
Comment:
Don't hang up page views with jobs
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -328,12 +328,16 @@
329329 */
330330 function finalCleanup ( &$deferredUpdates, &$output ) {
331331 wfProfileIn( __METHOD__ );
 332+ # Now commit any transactions, so that unreported errors after output() don't roll back the whole thing
 333+ $factory = wfGetLBFactory();
 334+ $factory->commitMasterChanges();
 335+ # Output everything!
 336+ $output->output();
 337+ # Do any deferred jobs
332338 $this->doUpdates( $deferredUpdates );
333339 $this->doJobs();
334 - # Now commit any transactions, so that unreported errors after output() don't roll back the whole thing
335 - $factory = wfGetLBFactory();
 340+ # Commit and close up!
336341 $factory->shutdown();
337 - $output->output();
338342 wfProfileOut( __METHOD__ );
339343 }
340344