r40543 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40542‎ | r40543 | r40544 >
Date:17:26, 6 September 2008
Author:mkroetzsch
Status:old
Tags:
Comment:
use proper constants for cache policy
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2_Queries.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2_Queries.php
@@ -386,8 +386,8 @@
387387 ///non-existing concept pages which is probably the main reason for finding nothing here
388388 } else {
389389 global $smwgQConceptCaching, $smwgQMaxSize, $smwgQMaxDepth, $smwgQFeatures, $smwgQConceptCacheLifetime;
390 - $may_be_computed = ($smwgQConceptCaching == 2) ||
391 - ( ($smwgQConceptCaching == 1) && ( (~(~($row->concept_features+0) | $smwgQFeatures)) == 0) &&
 390+ $may_be_computed = ($smwgQConceptCaching == CONCEPT_CACHE_NONE) ||
 391+ ( ($smwgQConceptCaching == CONCEPT_CACHE_HARD) && ( (~(~($row->concept_features+0) | $smwgQFeatures)) == 0) &&
392392 ($smwgQMaxSize >= $row->concept_size) && ($smwgQMaxDepth >= $row->concept_depth));
393393 if ($row->cache_date &&
394394 ($row->cache_date > (strtotime("now") - $smwgQConceptCacheLifetime*60) ||

Status & tagging log