r40525 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40524‎ | r40525 | r40526 >
Date:11:11, 6 September 2008
Author:mkroetzsch
Status:old
Tags:
Comment:
Print storage version on installation, issue a warning when old store is used
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore.php
@@ -1325,7 +1325,13 @@
13261326
13271327 function setup($verbose = true) {
13281328 global $wgDBtype;
1329 - $this->reportProgress("Setting up standard database configuration for SMW ...\n\n",$verbose);
 1329+ $this->reportProgress("Setting up database configuration for SMW ...\n\n",$verbose);
 1330+ $this->reportProgress("Selected storage engine is \"SMWSQLStore\" (or an extension thereof).\n\n",$verbose);
 1331+ $this->reportProgress("============================================================================\n", $verbose);
 1332+ $this->reportProgress("WARNING: This store is deprecated and will loose support in future versions!\n", $verbose);
 1333+ $this->reportProgress("Please consider switching your wiki to SQLStore2! For details, see\n",$verbose);
 1334+ $this->reportProgress("http://semantic-mediawiki.org/wiki/Help:Installation_1.2#Notes_on_Upgrading\n",$verbose);
 1335+ $this->reportProgress("============================================================================\n\n", $verbose);
13301336
13311337 if ($wgDBtype === 'postgres') {
13321338 $this->reportProgress("For Postgres, please import the file SMW_Postgres_Schema.sql manually\n",$verbose);
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
@@ -1085,6 +1085,7 @@
10861086 function setup($verbose = true) {
10871087 global $wgDBtype;
10881088 $this->reportProgress("Setting up standard database configuration for SMW ...\n\n",$verbose);
 1089+ $this->reportProgress("Selected storage engine is \"SMWSQLStore2\" (or an extension thereof)\n\n",$verbose);
10891090 if ($wgDBtype === 'postgres') {
10901091 $this->reportProgress("For Postgres, please import the file SMW_Postgres_Schema_2.sql manually\n",$verbose);
10911092 return;

Status & tagging log