r40417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40416‎ | r40417 | r40418 >
Date:03:58, 4 September 2008
Author:tstarling
Status:old
Tags:
Comment:
Display catchable fatal errors that won't be thrown
Modified paths:
  • /trunk/php/wmerrors/package2.xml (modified) (history)
  • /trunk/php/wmerrors/wmerrors.c (modified) (history)

Diff [purge]

Index: trunk/php/wmerrors/wmerrors.c
@@ -106,7 +106,9 @@
107107 TSRMLS_FETCH();
108108
109109 if ( !WMERRORS_G(enabled)
110 - || (type != E_ERROR && type != E_CORE_ERROR && type != E_COMPILE_ERROR && type != E_USER_ERROR)
 110+ || (type == E_RECOVERABLE_ERROR && PG(error_handling) == EH_THROW && !EG(exception))
 111+ || (type != E_ERROR && type != E_CORE_ERROR && type != E_COMPILE_ERROR
 112+ && type != E_USER_ERROR && type != E_RECOVERABLE_ERROR)
111113 || strncmp(sapi_module.name, "apache", 6)
112114 || WMERRORS_G(recursion_guard))
113115 {
Index: trunk/php/wmerrors/package2.xml
@@ -16,9 +16,9 @@
1717 <email>tstarling@wikimedia.org</email>
1818 <active>yes</active>
1919 </lead>
20 -<date>2008-07-26</date>
 20+<date>2008-09-04</date>
2121 <version>
22 - <release>1.0.1</release>
 22+ <release>1.0.2</release>
2323 <api>1.0.1</api>
2424 </version>
2525 <stability>
@@ -26,7 +26,7 @@
2727 <api>beta</api>
2828 </stability>
2929 <license>Whatever</license>
30 -<notes>Fixed bug on x86_64.</notes>
 30+<notes>Display catchable fatal errors that won't be thrown.</notes>
3131 <contents>
3232 <dir name="/">
3333 <file name="config.w32" role="src"/>