r40407 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40406‎ | r40407 | r40408 >
Date:22:45, 3 September 2008
Author:demon
Status:old
Tags:
Comment:
Remove unused $wgMessageCache globals.
Modified paths:
  • /trunk/extensions/AbsenteeLandlord/AbsenteeLandlord.php (modified) (history)
  • /trunk/extensions/Cache404/extensions/Cache404.php (modified) (history)
  • /trunk/extensions/Purge/Purge.php (modified) (history)
  • /trunk/extensions/SpecialFileList/SpecialFilelist.php (modified) (history)
  • /trunk/extensions/SpecialForm/SpecialForm.body.php (modified) (history)
  • /trunk/extensions/TodoTasks/SpecialTaskList_body.php (modified) (history)
  • /trunk/extensions/Watchers/Watchers.php (modified) (history)
  • /trunk/extensions/Wikidata/App.php (modified) (history)
  • /trunk/extensions/wikiforum/wikiforum.php (modified) (history)
  • /trunk/extensions/wikiwyg/share/MediaWiki/extensions/MediaWikiWyg.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SpecialFileList/SpecialFilelist.php
@@ -26,7 +26,7 @@
2727
2828 function wfSpecialFilelist () {
2929 wfLoadExtensionMessages( 'Filelist' );
30 - global $IP, $wgMessageCache;
 30+ global $IP;
3131 require_once "$IP/includes/SpecialPage.php";
3232 class SpecialFilelist extends SpecialPage {
3333
Index: trunk/extensions/wikiforum/wikiforum.php
@@ -509,7 +509,7 @@
510510 * @addtogroup Extensions
511511 */
512512 function wfForum() {
513 - global $IP, $wgMessageCache, $wgAllMessagesEn, $wgNavigationLinks, $wgTitle;
 513+ global $IP, $wgAllMessagesEn, $wgNavigationLinks, $wgTitle;
514514 require_once( $IP.'/includes/SpecialPage.php' );
515515
516516
Index: trunk/extensions/Cache404/extensions/Cache404.php
@@ -633,7 +633,7 @@
634634 global $wgUsePathInfo, $wgFilterCallback, $wgRequest, $wgUser, $wgOut, $_SERVER;
635635 global $wgAllowUserJs, $wgAllowUserCss, $wgUseSiteCss, $wgUseSiteJs, $wgCachePages;
636636 global $wgCache404SavedCallback;
637 - global $wgLang, $wgLanguageCode, $wgContLang, $wgContLanguageCode, $wgMessageCache,
 637+ global $wgLang, $wgLanguageCode, $wgContLang, $wgContLanguageCode,
638638 $messageMemc, $wgUseDatabaseMessages, $wgMsgCacheExpiry, $wgDBname;
639639
640640 # Prevent user options, user new talk
Index: trunk/extensions/Watchers/Watchers.php
@@ -81,7 +81,7 @@
8282 * The special page
8383 */
8484 function wfWatchersExtension() {
85 - global $IP, $wgMessageCache;
 85+ global $IP;
8686 wfWatchersAddCache();
8787
8888 require_once $IP.'/includes/SpecialPage.php';
Index: trunk/extensions/Purge/Purge.php
@@ -24,7 +24,7 @@
2525
2626 class PurgeAction {
2727 public function __construct() {
28 - global $wgMessageCache, $wgHooks;
 28+ global $wgHooks;
2929 wfLoadExtensionMessages( 'Purge' );
3030 $wgHooks['SkinTemplateContentActions'][] = array( &$this, 'contentHook' );
3131 #$wgHooks['ArticlePurge'][] = array( &$this, 'purgeHook' );
Index: trunk/extensions/SpecialForm/SpecialForm.body.php
@@ -66,7 +66,6 @@
6767
6868 function loadMessages() {
6969 static $messagesLoaded = false;
70 - global $wgMessageCache;
7170
7271 if ( $messagesLoaded ) return true;
7372 wfLoadExtensionMessages('SpecialForm');
Index: trunk/extensions/AbsenteeLandlord/AbsenteeLandlord.php
@@ -40,7 +40,7 @@
4141 $groups = $wgUser->getGroups();
4242
4343 if( !in_array( 'sysop', $groups ) ) {
44 - global $wgReadOnly, $wgMessageCache;
 44+ global $wgReadOnly;
4545
4646 #Add Messages (don't need them unless we get here)
4747 wfLoadExtensionMessages( 'AbsenteeLandlord' );
Index: trunk/extensions/TodoTasks/SpecialTaskList_body.php
@@ -2,7 +2,6 @@
33
44 function TaskListLoadMessages() {
55 static $messagesLoaded = false;
6 - global $wgMessageCache;
76 if ($messagesLoaded) return;
87 $messagesLoaded = true;
98 wfLoadExtensionMessages('TaskList');
Index: trunk/extensions/wikiwyg/share/MediaWiki/extensions/MediaWikiWyg.php
@@ -52,7 +52,7 @@
5353 global $wgOut, $wgSkin, $jsdir, $cssdir, $wgScriptPath;
5454 global $wgWikiwygPath, $wgUser, $wgTitle;
5555 global $wgServer, $wgWikiwygJsPath, $wgWikiwygCssPath, $wgWikiwygImagePath;
56 - global $wgRequest, $wgWysiwygEnabled, $wgMessageCache;
 56+ global $wgRequest, $wgWysiwygEnabled;
5757 global $wgLang, $wgContLang, $wgEnableAjaxLogin;
5858
5959 wfLoadExtensionMessages('Wikiwyg');
Index: trunk/extensions/Wikidata/App.php
@@ -174,8 +174,7 @@
175175 }
176176
177177 function initializeWikidata() {
178 - global
179 - $wgMessageCache, $wgExtensionPreferences, $wdSiteContext, $wgPropertyToColumnFilters;
 178+ global $wgExtensionPreferences, $wdSiteContext, $wgPropertyToColumnFilters;
180179
181180 $dbr =& wfGetDB(DB_MASTER);
182181 $dbr->query("SET NAMES utf8");

Status & tagging log