r40386 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r40385‎ | r40386 | r40387 >
Date:16:57, 3 September 2008
Author:brion
Status:old
Tags:
Comment:
Delay rendering of thumbnails in results; on Wikimedia cluster they'll be rendered on demand, with rendering done through proper channels (separate subcluster). Previously it would try to render them immediately, on the text server cluster, which is "bad".
Modified paths:
  • /trunk/extensions/OpenSearchXml/ApiOpenSearchXml.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenSearchXml/ApiOpenSearchXml.php
——@@ -103,7 +103,7 @@
104104 $item['Description']['*'] = $extract;
105105 $item['Url']['*'] = $title->getFullUrl();
106106 if( $image ) {
107 - $thumb = $image->getThumbnail( 50, 50 );
 107+ $thumb = $image->getThumbnail( 50, 50, false );
108108 $item['Image'] = array(
109109 'source' => wfExpandUrl( $thumb->getUrl() ),
110110 //alt