r40383 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40382‎ | r40383 | r40384 >
Date:14:26, 3 September 2008
Author:catrope
Status:old
Tags:
Comment:
(bug 15444) API: Throwing a regular 'unknownerror' rather than ('unknownerror', AS_END) when EditPage::AS_END is returned, for consistency with other write modules.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiEditPage.php
@@ -205,7 +205,7 @@
206206 case EditPage::AS_END:
207207 # This usually means some kind of race condition
208208 # or DB weirdness occurred. Throw an unknown error here.
209 - $this->dieUsageMsg(array('unknownerror', 'AS_END'));
 209+ $this->dieUsageMsg(array('unknownerror'));
210210 case EditPage::AS_SUCCESS_NEW_ARTICLE:
211211 $r['new'] = '';
212212 case EditPage::AS_SUCCESS_UPDATE:
Index: trunk/phase3/RELEASE-NOTES
@@ -208,8 +208,9 @@
209209 * Database replication lag doesn't cause all action=edit requests to return the
210210 nochange flag any more
211211 * (bug 15392) ApiFormatBase::formatHTML now uses $wgUrlProtocols.
 212+* (bug 15444) action=edit returned "Unknown error: ``AS_END''" where it should
 213+ return just "Unknown error"
212214
213 -
214215 === Languages updated in 1.14 ===
215216
216217 MediaWiki supports over 300 languages. Many localisations are updated