| Index: trunk/extensions/SemanticMediaWiki/includes/SMW_DataValueFactory.php |
| — | — | @@ -221,7 +221,9 @@ |
| 222 | 222 | |
| 223 | 223 | /** |
| 224 | 224 | * Quickly get the type value of some property without necessarily making another datavalue. |
| 225 | | - * FIXME not efficient |
| | 225 | + * @note The internal error type id is returned if this method failed to find the type. |
| | 226 | + * @bug This method is not implemented efficiently. |
| | 227 | + * @todo This method is mainly used in the processing of multi-valued properties. Revise all its uses. |
| 226 | 228 | */ |
| 227 | 229 | static public function getPropertyObjectTypeValue(Title $property) { |
| 228 | 230 | $propertyname = $property->getText(); |
| — | — | @@ -229,7 +231,7 @@ |
| 230 | 232 | if (array_key_exists($propertyname, SMWDataValueFactory::$m_typebyproperty)) { |
| 231 | 233 | return SMWDataValueFactory::$m_typebyproperty[$propertyname]; |
| 232 | 234 | } else { // no type found |
| 233 | | - return NULL; |
| | 235 | + return new SMWTypesValue('__err'); |
| 234 | 236 | } |
| 235 | 237 | } |
| 236 | 238 | |