r40197 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40196‎ | r40197 | r40198 >
Date:23:36, 28 August 2008
Author:yaron
Status:old
Tags:
Comment:
Fixed SQL for 'none' value for SMWSQLStore2
Modified paths:
  • /trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php
@@ -307,10 +307,10 @@
308308 $property_value = str_replace(' ', '_', $af->filter->property);
309309 $property_value = str_replace("'", "\'", $property_value);
310310 $sql .= "LEFT OUTER JOIN
311 - (SELECT subject_id, $value_field
 311+ (SELECT s_id, $value_field
312312 FROM $property_table_name
313313 WHERE $property_field = '$property_value') $property_table_nickname
314 - ON id.smw_id = $property_table_nickname.s_id ";
 314+ ON ids.smw_id = $property_table_nickname.s_id ";
315315 }
316316 }
317317 foreach ($applied_filters as $i => $af) {

Status & tagging log