r40113 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r40112‎ | r40113 | r40114 >
Date:22:23, 27 August 2008
Author:ialex
Status:old
Tags:
Comment:
(bug 15342) "Invert" checkbox now works correctly when selecting main namespace in Special:Watchlist
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWatchlist.php
@@ -81,7 +81,7 @@
8282 $invert = $wgRequest->getIntOrNull( 'invert' );
8383 if( !is_null( $nameSpace ) ) {
8484 $nameSpace = intval( $nameSpace );
85 - if( $invert && $nameSpace != 'all' )
 85+ if( $invert && $nameSpace !== 'all' )
8686 $nameSpaceClause = " AND rc_namespace != $nameSpace";
8787 else
8888 $nameSpaceClause = " AND rc_namespace = $nameSpace";
Index: trunk/phase3/RELEASE-NOTES
@@ -151,6 +151,8 @@
152152 * (bug 15303) Title conversion for templates wasn't working in some cases.
153153 * (bug 15264) Underscores in Special:Search/Foo_bar parameters were taken
154154 literally; now converting them to spaces per expectation.
 155+* (bug 15342) "Invert" checkbox now works correctly when selecting main
 156+ namespace in Special:Watchlist
155157
156158
157159 === API changes in 1.14 ===