r39987 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39986‎ | r39987 | r39988 >
Date:23:53, 25 August 2008
Author:stipe
Status:old
Tags:
Comment:
fixed stream selection dialog
Modified paths:
  • /trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MetavidWiki/skins/mv_embed/mv_embed.js
@@ -2272,9 +2272,9 @@
22732273 image_src += '.png';
22742274 if (default_player)
22752275 {
2276 - var retval = '<img src="'+image_src+'"/>';
 2276+ out += '<img src="'+image_src+'"/>';
22772277 if(is_not_selected)
2278 - retval+='<a href="#" onClick="' + source_select_code + 'embedTypes.players.userSelectPlayer(\''+default_player.id+'\',\''+source.getMIMEType()+'\'); return false;">';
 2278+ out+='<a href="#" onClick="' + source_select_code + 'embedTypes.players.userSelectPlayer(\''+default_player.id+'\',\''+source.getMIMEType()+'\'); return false;">';
22792279 out += source.getTitle()+/*' - ' + default_player.getName() +*/ (is_not_selected?'</a>':'') + ' ';
22802280 out += /*'(<a href="#" onClick=\'$j("#player_select_list_'+index+'").fadeIn("slow");return false;\'>choose player</a>)' +*/ player_code;
22812281 }else

Status & tagging log