r39941 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39940‎ | r39941 | r39942 >
Date:09:44, 25 August 2008
Author:midom
Status:old
Tags:
Comment:
revert rev#36938
Modified paths:
  • /trunk/phase3/includes/specials/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialNewpages.php
@@ -231,7 +231,7 @@
232232 global $wgLang, $wgContLang, $wgUser;
233233 $dm = $wgContLang->getDirMark();
234234
235 - $title = Title::makeTitleSafe( $result->page_namespace, $result->page_title );
 235+ $title = Title::makeTitleSafe( $result->rc_namespace, $result->rc_title );
236236 $time = $wgLang->timeAndDate( $result->rc_timestamp, true );
237237 $plink = $this->skin->makeKnownLinkObj( $title, '', $this->patrollable( $result ) ? 'rcid=' . $result->rc_id : '' );
238238 $hist = $this->skin->makeKnownLinkObj( $title, wfMsgHtml( 'hist' ), 'action=history' );
@@ -305,7 +305,7 @@
306306 }
307307
308308 protected function feedItem( $row ) {
309 - $title = Title::MakeTitle( intval( $row->page_namespace ), $row->page_title );
 309+ $title = Title::MakeTitle( intval( $row->rc_namespace ), $row->rc_title );
310310 if( $title ) {
311311 $date = $row->rc_timestamp;
312312 $comments = $title->getTalkPage()->getFullURL();
@@ -379,7 +379,7 @@
380380 $user = Title::makeTitleSafe( NS_USER, $username );
381381
382382 if( $namespace !== false ) {
383 - $conds['page_namespace'] = $namespace;
 383+ $conds['rc_namespace'] = $namespace;
384384 $rcIndexes = array( 'new_name_timestamp' );
385385 } else {
386386 $rcIndexes = array( 'rc_timestamp' );
@@ -404,7 +404,7 @@
405405
406406 return array(
407407 'tables' => array( 'recentchanges', 'page' ),
408 - 'fields' => 'page_namespace,page_title, rc_cur_id, rc_user,rc_user_text,rc_comment,
 408+ 'fields' => 'rc_namespace,rc_title, rc_cur_id, rc_user,rc_user_text,rc_comment,
409409 rc_timestamp,rc_patrolled,rc_id,page_len as length, page_latest as rev_id',
410410 'conds' => $conds,
411411 'options' => array( 'USE INDEX' => array('recentchanges' => $rcIndexes) )
@@ -425,7 +425,7 @@
426426 while( $row = $this->mResult->fetchObject() ) {
427427 $linkBatch->add( NS_USER, $row->rc_user_text );
428428 $linkBatch->add( NS_USER_TALK, $row->rc_user_text );
429 - $linkBatch->add( $row->page_namespace, $row->page_title );
 429+ $linkBatch->add( $row->rc_namespace, $row->rc_title );
430430 }
431431 $linkBatch->execute();
432432 return "<ul>";

Status & tagging log