r39836 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r39835‎ | r39836 | r39837 >
Date:15:28, 22 August 2008
Author:simetrical
Status:old
Tags:
Comment:
Tweak for r39314: don't add a line break before the "Go" button on the watchlist. This used up yet more vertical space. It also visually dissociated the "Go" button from the namespace selector, making it look like it maybe applied to all the buttons above too, due to lack of a fieldset. On the other hand, this way looks a little awkward too. Maybe there's a better way?

Reported by User:Garion96 on [[WP:VPT]]: <http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&amp;oldid=233532922#.22go.22_button_in_watchlist&gt;
Modified paths:
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWatchlist.php
——@@ -279,7 +279,7 @@
280280 $form .= '<p>';
281281 $form .= Xml::label( wfMsg( 'namespace' ), 'namespace' ) . '&nbsp;';
282282 $form .= Xml::namespaceSelector( $nameSpace, '' ) . '&nbsp;';
283 - $form .= Xml::checkLabel( wfMsg('invert'), 'invert', 'nsinvert', $invert ) . "<br />";
 283+ $form .= Xml::checkLabel( wfMsg('invert'), 'invert', 'nsinvert', $invert ) . '&nbsp;';
284284 $form .= Xml::submitButton( wfMsg( 'allpagessubmit' ) ) . '</p>';
285285 $form .= Xml::hidden( 'days', $days );
286286 if( $hideMinor )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39314(bug 15157) Special:Watchlist now has the same options as Special:Watchlist:...siebrand23:08, 13 August 2008

Status & tagging log