r39772 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r39771‎ | r39772 | r39773 >
Date:16:27, 21 August 2008
Author:brion
Status:old
Tags:
Comment:
Fix regressions in our hosted services...
* Bogus renaming of class without fixing up the old-style constructor name
DO NOT MAKE THIS KIND OF CHANGE WITHOUT TESTING YOUR CHANGE. YOU CREATED A FATAL ERROR WHICH COMPLETELY BROKE THE EXTENSION.
* Bogus alias file for machine-readable entry points -- this is not a human interface and should not be localized.
Modified paths:
  • /trunk/extensions/OAI/OAIRepo.alias.php (deleted) (history)
  • /trunk/extensions/OAI/OAIRepo.php (modified) (history)
  • /trunk/extensions/OAI/OAIRepo_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OAI/OAIRepo.alias.php
——@@ -1,11 +0,0 @@
2 -<?php
3 -/**
4 - * Aliases for special pages
5 - *
6 - */
7 -
8 -$aliases = array();
9 -
10 -$aliases['en'] = array(
11 - 'OAIRepository' => array( 'OAIRepository' ),
12 -);
Index: trunk/extensions/OAI/OAIRepo_body.php
——@@ -16,7 +16,7 @@
1717 }
1818
1919 class SpecialOAIRepository extends UnlistedSpecialPage {
20 - function OAIRepository() {
 20+ function __construct() {
2121 UnlistedSpecialPage::UnlistedSpecialPage( 'OAIRepository' );
2222 }
2323
Index: trunk/extensions/OAI/OAIRepo.php
——@@ -67,7 +67,6 @@
6868
6969 $dir = dirname(__FILE__) . '/';
7070 $wgExtensionMessagesFiles['OAIRepository'] = $dir . 'OAIRepo.i18n.php';
71 -$wgExtensionAliasesFiles['OAIRepository'] = $dir . 'OAIRepo.alias.php';
7271 $wgAutoloadClasses['SpecialOAIRepository'] = $dir . 'OAIRepo_body.php';
7372 $wgSpecialPages['OAIRepository'] = 'SpecialOAIRepository';
7473

Status & tagging log