r39649 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39648‎ | r39649 | r39650 >
Date:17:24, 19 August 2008
Author:brion
Status:old
Tags:
Comment:
Revert r39546 "(bug 14187) In Special:Userlogin the buttons "Log in" and "E-mail new password" now have classes "mw-loginbutton" and "mw-mailmypasswordbutton"."
There's no need to add classes when they already have IDs...
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/templates/Userlogin.php
@@ -79,7 +79,7 @@
8080 <tr>
8181 <td></td>
8282 <td class="mw-submit">
83 - <input type='submit' class="mw-loginbutton" name="wpLoginattempt" id="wpLoginattempt" tabindex="5" value="<?php $this->msg('login') ?>" />&nbsp;<?php if( $this->data['useemail'] && $this->data['canreset']) { ?><input type='submit' class="mw-mailmypasswordbutton" name="wpMailmypassword" id="wpMailmypassword"
 83+ <input type='submit' name="wpLoginattempt" id="wpLoginattempt" tabindex="5" value="<?php $this->msg('login') ?>" />&nbsp;<?php if( $this->data['useemail'] && $this->data['canreset']) { ?><input type='submit' name="wpMailmypassword" id="wpMailmypassword"
8484 tabindex="6"
8585 value="<?php $this->msg('mailmypassword') ?>" />
8686 <?php } ?>
Index: trunk/phase3/RELEASE-NOTES
@@ -88,8 +88,6 @@
8989 Show/Hide logged in users, Show/Hide anonymous, Invert namespace selection
9090 * Added hook 'UserrightsChangeableGroups' to allow modification of what
9191 groups may be added or removed via the Special:UserRights interface.
92 -* (bug 14187) In Special:Userlogin the buttons "Log in" and "E-mail new
93 - password" now have classes "mw-loginbutton" and "mw-mailmypasswordbutton".
9492 * HTML entities like &nbsp; now work (are not escaped) in edit summaries.
9593 * (bug 13815) In the comment for page moves, use the colon-separator message
9694 instead of a hardcoded colon.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39546(bug 14187) In Special:Userlogin the buttons "Log in" and "E-mail new passwor...siebrand19:25, 17 August 2008

Status & tagging log