r39624 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39623‎ | r39624 | r39625 >
Date:01:19, 19 August 2008
Author:dantman
Status:old
Tags:
Comment:
Revert 39613; Please don't mark that function static. It is not called statically, and is not meant to be. That is meant as a test to see if there are any markers inside of part of the string being worked on.
Ideally in the future markers will have unique identifier so that using multiple link marker replacers don't clash with each other.
Modified paths:
  • /trunk/phase3/includes/parser/Parser_LinkHooks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser_LinkHooks.php
@@ -362,7 +362,7 @@
363363 return "<!-- LINKMARKER $id -->";
364364 }
365365
366 - static function findMarker( $string ) {
 366+ function findMarker( $string ) {
367367 return (bool) preg_match('/<!-- LINKMARKER [0-9]+ -->/', $string );
368368 }
369369

Status & tagging log