r39594 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r39593‎ | r39594 | r39595 >
Date:17:22, 18 August 2008
Author:rotem
Status:old
Tags:
Comment:
Fix regression from r39373: * marks were changed to *? , which broke the colon in comments because the regexp did not recognize the post text. Reverting to the original regexp. Tested on some comments (as well as on Wikipedia:Translation/*/Lang/de mentioned in the previous commit), but if it breaks anything, please revert and fix in another way.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -1188,7 +1188,7 @@
11891189 $this->autocommentTitle = $title;
11901190 $this->autocommentLocal = $local;
11911191 $comment = preg_replace_callback(
1192 - '!(.*?)/\*\s*(.*?)\s*\*/(.*?)!',
 1192+ '!(.*)/\*\s*(.*?)\s*\*/(.*)!',
11931193 array( $this, 'formatAutocommentsCallback' ),
11941194 $comment );
11951195 unset( $this->autocommentTitle );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39373* Avoid recursive crazy expansions in section edit comments for pages which c...brion23:33, 14 August 2008

Status & tagging log