r39586 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39585‎ | r39586 | r39587 >
Date:14:19, 18 August 2008
Author:ialex
Status:old
Tags:
Comment:
Use colon-separator message after summary, summary-preview, subject and subject-preview instead of hardcoding a ":" after it
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1213,8 +1213,9 @@
12141214 #if ( "no" == $redirect ) { $q .= "&redirect=no"; }
12151215 $action = $wgTitle->escapeLocalURL( $q );
12161216
1217 - $summary = wfMsg('summary');
1218 - $subject = wfMsg('subject');
 1217+ $colonSep = wfMsg( 'colon-separator' );
 1218+ $summary = wfMsg( 'summary' ) . $colonSep;
 1219+ $subject = wfMsg( 'subject' ) . $colonSep;
12191220
12201221 $cancel = $sk->makeKnownLink( $wgTitle->getPrefixedText(),
12211222 wfMsgExt('cancel', array('parseinline')) );
@@ -1291,16 +1292,16 @@
12921293 $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
12931294 $summaryhiddens .= Xml::hidden( 'wpAutoSummary', $autosumm );
12941295 if( $this->section == 'new' ) {
1295 - $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
 1296+ $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}</label></span>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
12961297 $editsummary = "<div class='editOptions'>\n";
12971298 global $wgParser;
12981299 $formattedSummary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $this->summary ) );
1299 - $subjectpreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('subject-preview').':'.$sk->commentBlock( $formattedSummary, $this->mTitle, true )."</div>\n" : '';
 1300+ $subjectpreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('subject-preview').$colonSep.$sk->commentBlock( $formattedSummary, $this->mTitle, true )."</div>\n" : '';
13001301 $summarypreview = '';
13011302 } else {
13021303 $commentsubject = '';
1303 - $editsummary="<div class='editOptions'>\n<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
1304 - $summarypreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('summary-preview').':'.$sk->commentBlock( $this->summary, $this->mTitle )."</div>\n" : '';
 1304+ $editsummary="<div class='editOptions'>\n<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}</label></span>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
 1305+ $summarypreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('summary-preview').$colonSep.$sk->commentBlock( $this->summary, $this->mTitle )."</div>\n" : '';
13051306 $subjectpreview = '';
13061307 }
13071308

Status & tagging log