r39521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39520‎ | r39521 | r39522 >
Date:08:45, 17 August 2008
Author:werdna
Status:old
Tags:
Comment:
A few mistakes in messages
Modified paths:
  • /trunk/extensions/DeleteQueue/DeleteQueue.i18n.php (modified) (history)
  • /trunk/extensions/DeleteQueue/DeleteQueueInterface.php (modified) (history)
  • /trunk/extensions/DeleteQueue/ReviewForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DeleteQueue/DeleteQueue.i18n.php
@@ -18,15 +18,15 @@
1919 'deletequeue-action' => 'Suggest deletion',
2020 'deletequeue-action-title' => "Suggest deletion of \"$1\"",
2121 'deletequeue-action-text' => "{{SITENAME}} has a number of processes for deleting pages:
22 -*If you believe that this page warrants ''speedy deletion'', you may suggest that [{{fullurl:{{PAGENAME}}|action=delnom|queue=speedy}} here].
23 -*If this page does not warrant speedy deletion, but ''deletion will likely be uncontroversial'', you should [{{fullurl:{{PAGENAME}}|action=delnom|queue=prod}} propose uncontested deletion].
24 -*If this page's deletion is ''likely to be contested'', you should [{{fullurl:{{PAGENAME}}|action=delnom|queue=deletediscuss}} open a discussion].",
 22+*If you believe that this page warrants ''speedy deletion'', you may suggest that [{{fullurl:{{PAGENAME}}|action=delnom&queue=speedy}} here].
 23+*If this page does not warrant speedy deletion, but ''deletion will likely be uncontroversial'', you should [{{fullurl:{{PAGENAME}}|action=delnom&queue=prod}} propose uncontested deletion].
 24+*If this page's deletion is ''likely to be contested'', you should [{{fullurl:{{PAGENAME}}|action=delnom&queue=deletediscuss}} open a discussion].",
2525
2626 // Permissions errors
27 - 'deletequeue-permissions-noedit' => "You must be able to edit a page to be able to affect its deletion status. $1",
 27+ 'deletequeue-permissions-noedit' => "You must be able to edit a page to be able to affect its deletion status.",
2828
2929 // Nomination forms
30 - 'deletequeue-generic-reasons' => "* Blah\n** Blah blah!\n** Blah blah blah!\n*Moo\n** Mooey pooey!\n** Pooey mooey!",
 30+ 'deletequeue-generic-reasons' => "* Generic reasons\n ** Vandalism\n ** Spam\n ** Maintenance\n ** Out of project scope",
3131
3232 // Speedy deletion
3333 'deletequeue-speedy-title' => 'Mark "$1" for speedy deletion',
@@ -89,9 +89,8 @@
9090 'deletequeue-review-newextra' => 'Extra information:',
9191 'deletequeue-review-submit' => 'Save Review',
9292 'deletequeue-review-original' => "Reason for nomination",
93 - 'deletequeue-actiondisabled-involved' => 'You have taken part in this deletion case in the following roles: $1',
94 - 'deletequeue-actiondisabled-notexpired' => 'the deletion nomination has not yet expired',
95 - 'deletequeue-actiondisabled' => 'The following action is disabled because $1:',
 93+ 'deletequeue-actiondisabled-involved' => 'The following action is disabled because you have taken part in this deletion case in the roles $1:',
 94+ 'deletequeue-actiondisabled-notexpired' => 'The following action is disabled because the deletion nomination has not yet expired:',
9695 'deletequeue-review-badaction' => 'You specified an invalid action',
9796 'deletequeue-review-actiondenied' => 'You specified an action which is disabled for this page',
9897 "deletequeue-review-objections" => "'''Warning''': The deletion of this page has [{{FULLURL:{{PAGENAME}}|action=delvoteview|votetype=object}} objections].
Index: trunk/extensions/DeleteQueue/ReviewForm.php
@@ -232,7 +232,7 @@
233233 list ($enabled,$disabled) = $this->availableActions();
234234
235235 if (!$disabledMsg) {
236 - $disabledMsg = wfMsgExt("deletequeue-review-$action", array('parseinline'));
 236+ $disabledMsg = wfMsgExt("deletequeue-review-$action", array('parse'));
237237 }
238238
239239 $data = '';
@@ -240,7 +240,7 @@
241241 if (in_array($action,$enabled)) {
242242 $data = $enabledText;
243243 } elseif ( in_array( $action, array_keys( $disabled ) ) ) {
244 - $msg = wfMsgExt( 'deletequeue-actiondisabled', array( 'parse' ), array( $disabled[$action] ) );
 244+ $msg = $disabled[$action];
245245 $msg .= "\n";
246246 $msg .= $disabledMsg;
247247 $data = $msg;
Index: trunk/extensions/DeleteQueue/DeleteQueueInterface.php
@@ -19,11 +19,15 @@
2020 if (count(array_merge($editErrors,$nomErrors))) {
2121 // Permissions errors.
2222 if (count($editErrors)) {
 23+ // This is a really bad way to do this.
2324 $editError = $wgOut->formatPermissionsErrorMessage( $editErrors, 'edit' );
2425 $nomErrors[] = array( 'deletequeue-permissions-noedit', $editError );
2526 }
2627
2728 $wgOut->showPermissionsErrorPage( $nomErrors, "{$queue}-nominate" );
 29+ if (isset($editError)) {
 30+ $wgOut->addHTML( $editError );
 31+ }
2832 return;
2933 }
3034

Status & tagging log