r39421 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39420‎ | r39421 | r39422 >
Date:18:28, 15 August 2008
Author:aaron
Status:old
Tags:
Comment:
double-check with isLocal() to be safe
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllpages.php
@@ -114,8 +114,8 @@
115115
116116 $from = Title::makeTitleSafe( $namespace, $from );
117117 $to = Title::makeTitleSafe( $namespace, $to );
118 - $from = $from ? $from->getDBKey() : null;
119 - $to = $to ? $to->getDBKey() : null;
 118+ $from = ( $from && $from->isLocal() ) ? $from->getDBKey() : null;
 119+ $to = ( $to && $to->isLocal() ) ? $to->getDBKey() : null;
120120
121121 if( isset($from) )
122122 $where[] = 'page_title >= '.$dbr->addQuotes( $from );

Status & tagging log