r39415 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39414‎ | r39415 | r39416 >
Date:16:51, 15 August 2008
Author:ialex
Status:old
Tags:
Comment:
Fixes for r39406:
* Set missing properties svn:eol-style and svn:mime-type
* Use auto loader if possible
* Added $wgEnableHtmlDiff to DefaultSettings.php (todo: fix description of this setting)
Modified paths:
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/includes/HTMLDiff.php (modified) (history)
  • /trunk/phase3/skins/common/images/diffunderline.gif (modified) (history)

Diff [purge]

Property changes on: trunk/phase3/skins/common/images/diffunderline.gif
___________________________________________________________________
Name: svn:mime-type
11 + image/gif
Property changes on: trunk/phase3/includes/HTMLDiff.php
___________________________________________________________________
Name: svn:eol-style
22 + native
Index: trunk/phase3/includes/AutoLoader.php
@@ -32,6 +32,7 @@
3333 'ConcatenatedGzipHistoryBlob' => 'includes/HistoryBlob.php',
3434 'ConstantDependency' => 'includes/CacheDependency.php',
3535 'DBABagOStuff' => 'includes/BagOStuff.php',
 36+ 'DelegatingContentHandler' => 'includes/HTMLDiff.php',
3637 'DependencyWrapper' => 'includes/CacheDependency.php',
3738 '_DiffEngine' => 'includes/DifferenceEngine.php',
3839 'DifferenceEngine' => 'includes/DifferenceEngine.php',
@@ -57,6 +58,7 @@
5859 'DumpOutput' => 'includes/Export.php',
5960 'DumpPipeOutput' => 'includes/Export.php',
6061 'eAccelBagOStuff' => 'includes/BagOStuff.php',
 62+ 'EchoingContentHandler' => 'includes/HTMLDiff.php',
6163 'EditPage' => 'includes/EditPage.php',
6264 'EmaillingJob' => 'includes/EmaillingJob.php',
6365 'EmailNotification' => 'includes/UserMailer.php',
@@ -90,7 +92,9 @@
9193 'HistoryBlobStub' => 'includes/HistoryBlob.php',
9294 'HTMLCacheUpdate' => 'includes/HTMLCacheUpdate.php',
9395 'HTMLCacheUpdateJob' => 'includes/HTMLCacheUpdate.php',
 96+ 'HTMLDiffer' => 'includes/HTMLDiff.php',
9497 'HTMLFileCache' => 'includes/HTMLFileCache.php',
 98+ 'HTMLOutput' => 'includes/HTMLDiff.php',
9599 'Http' => 'includes/HttpFunctions.php',
96100 '_HWLDF_WordAccumulator' => 'includes/DifferenceEngine.php',
97101 'ImageGallery' => 'includes/ImageGallery.php',
@@ -150,6 +154,7 @@
151155 'ProtectionForm' => 'includes/ProtectionForm.php',
152156 'QueryPage' => 'includes/QueryPage.php',
153157 'QuickTemplate' => 'includes/SkinTemplate.php',
 158+ 'RangeDifference' => 'includes/DifferenceEngine.php',
154159 'RawPage' => 'includes/RawPage.php',
155160 'RCCacheEntry' => 'includes/ChangesList.php',
156161 'RecentChange' => 'includes/RecentChange.php',
Index: trunk/phase3/includes/DifferenceEngine.php
@@ -327,13 +327,11 @@
328328
329329
330330 function renderHtmlDiff() {
331 - global $wgOut, $IP;
 331+ global $wgOut;
332332 wfProfileIn( __METHOD__ );
333333
334334 $this->showDiffStyle();
335335
336 - require_once( "$IP/includes/HTMLDiff.php" );
337 -
338336 #add deleted rev tag if needed
339337 if( !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
340338 $wgOut->addWikiMsg( 'rev-deleted-text-permission' );
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2377,6 +2377,9 @@
23782378 /** Name of the external diff engine to use */
23792379 $wgExternalDiffEngine = false;
23802380
 2381+/** Whether to use inline diff */
 2382+$wgEnableHtmlDiff = false;
 2383+
23812384 /** Use RC Patrolling to check for vandalism */
23822385 $wgUseRCPatrol = true;
23832386

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39406New implementation of wikidiff3 algorithm replacing the previous one and basi...guyvdb11:46, 15 August 2008

Status & tagging log