r39313 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39312‎ | r39313 | r39314 >
Date:23:07, 13 August 2008
Author:brion
Status:old
Tags:
Comment:
r39299 cleanup -- use " around escaped attributes to be sure
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -125,7 +125,7 @@
126126 $wgOut->addWikiText( wfMsg( 'checkuser-summary' ) .
127127 "\n\n[[" . $this->getLogSubpageTitle()->getPrefixedText() . '|' . wfMsg( 'checkuser-showlog' ) . ']]'
128128 );
129 - $form = "<form name='checkuserform' id='checkuserform' action='$action' method='post'>";
 129+ $form = "<form name='checkuserform' id='checkuserform' action=\"$action\" method='post'>";
130130 $form .= "<fieldset><legend>".wfMsgHtml( "checkuser-query" )."</legend>";
131131 $form .= "<table border='0' cellpadding='2'><tr>";
132132 $form .= "<td>".wfMsgHtml( "checkuser-target" ).":</td>";
@@ -605,7 +605,7 @@
606606 $blocklist = SpecialPage::getTitleFor( 'Ipblocklist' );
607607
608608 $action = $wgTitle->escapeLocalUrl( 'action=block' );
609 - $s = "<form name='checkuserblock' id='checkuserblock' action='$action' method='post'>";
 609+ $s = "<form name='checkuserblock' id='checkuserblock' action=\"$action\" method='post'>";
610610 $s .= '<ul>';
611611 foreach( $users_edits as $name => $count ) {
612612 $s .= '<li>';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39299* Add checkbox blocking/tagging (bug 12808)...aaron17:02, 13 August 2008

Status & tagging log